Reka Norman has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70054 )
Change subject: util/ifdtool/Makefile.inc: Respect LDFLAGS from environment ......................................................................
util/ifdtool/Makefile.inc: Respect LDFLAGS from environment
The ChromeOS build system performs ASAN builds by appending -fsanitize=address to CFLAGS and LDFLAGS. Currently, the ASAN build of ifdtool fails with linker errors because the Makefile does not respect LDFLAGS.
Modify the Makefile to respect LDFLAGS from the environment. This is consistent with the Makefiles of most other coreboot utils.
BUG=b:255462682 TEST=`USE=asan emerge-nissa coreboot-utils` now succeeds with CL:4018976
Change-Id: I1a497562d4d979829edb47c4c4b3f2c64266324e Signed-off-by: Reka Norman rekanorman@chromium.org --- M util/ifdtool/Makefile.inc 1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/70054/1
diff --git a/util/ifdtool/Makefile.inc b/util/ifdtool/Makefile.inc index eb3a700..2b97bf5 100644 --- a/util/ifdtool/Makefile.inc +++ b/util/ifdtool/Makefile.inc @@ -16,4 +16,4 @@
$(objutil)/ifdtool/ifdtool: $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) printf " IFDTOOL\n" - $(HOSTCC) $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) -o $@ + $(HOSTCC) ${LDFLAGS} $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) -o $@