Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Pranava Y N.
Subrata Banik has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/82637?usp=email )
Change subject: mb/google/brya/variants/trulo: Support OCP fault on A0/1 ports
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82637/comment/75541c5a_cb9cb4fd?usp... :
PS1, Line 14:
No Signed-off-by line in commit message
File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/82637/comment/df2a04ab_fb91b550?usp... :
PS1, Line 3: register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC1)" # USB3/2 Type A port A0
: register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC2)" # USB3/2 Type A port A1
:
this should be added in the variant devicetree IMO as each variant could have different HW design
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82637?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic17debc5eecebca8c000c43a660e1b52d2932f2a
Gerrit-Change-Number: 82637
Gerrit-PatchSet: 1
Gerrit-Owner: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 24 May 2024 08:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No