[M] Change in coreboot[main]: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver

[Felix Held (Code Review)]

Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.

Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85634?usp=email )

Change subject: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
......................................................................

Patch Set 21:

(2 comments)

File src/drivers/amd/opensil/memmap.c:

https://review.coreboot.org/c/coreboot/+/85634/comment/f70f7e2a_9d87d25a?usp... :
PS21, Line 50: strcmp
shouldn't this be 'if (!strcmp(...))'? strcmp return 0 on match and non-zero on mismatch and the existing code did a continue when this is a MMIO range

https://review.coreboot.org/c/coreboot/+/85634/comment/774da3eb_25bbf2fe?usp... :
PS21, Line 56: 		if (strcmp(opensil_get_hole_info_type(holes[hole].type), "UMA"))
probably same here