Attention is currently required from: Arthur Heymans, Marvin Drees.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68120 )
Change subject: util/amdfwutil: Add some types to both LVL
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/68120/comment/dcaa661e_f7fe9dc6
PS2, Line 239: PSP_BOTH_AB
I think most things are rather expected in level 2 and not both as level 1 is meant to house sane de […]
In Mendocino, AMD advised us to put PSP stage1 BL only in LVL2. We did not study the effect on putting it in both Levels.
Also on systems with limited flash space, this will eat up some space unnecessarily.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68120
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb838396baf79f32823ca271f55456570ba40c20
Gerrit-Change-Number: 68120
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Comment-Date: Wed, 16 Nov 2022 17:45:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marvin Drees
marvin.drees@9elements.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment