Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76919?usp=email )
Change subject: soc/mediatek/mt8188: Support ARM arch timer
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76919/comment/bd39aadf_8a6ca807 :
PS1, Line 15: check timestamps by cbmem.
Sorry, I meant `Cq-Depend: chromium:4747539` (not used in upstream, but will have an effect in the c […]
Done
File src/soc/mediatek/mt8188/timer.c:
https://review.coreboot.org/c/coreboot/+/76919/comment/c8d1ca2b_8393dc4c :
PS3, Line 6:
Is the blank line intentional?
removed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76919?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b1348044e4c92984510604b7f61611e13284d86
Gerrit-Change-Number: 76919
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sat, 05 Aug 2023 04:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment