Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46691 )
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
nb/intel/haswell/gma.c: Drop space after unary `!`
Change-Id: I72f75f3df50af362874818f2c1883a6a1c741087 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/46691/1
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index dc7b629..989d100 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -485,7 +485,7 @@ } }
- if (! lightup_ok) { + if (!lightup_ok) { printk(BIOS_SPEW, "FUI did not run; using VBIOS\n"); mdelay(CONFIG_PRE_GRAPHICS_DELAY); pci_dev_init(dev);
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46691
to look at the new patch set (#4).
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
nb/intel/haswell/gma.c: Drop space after unary `!`
Change-Id: I72f75f3df50af362874818f2c1883a6a1c741087 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/46691/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46691
to look at the new patch set (#5).
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
nb/intel/haswell/gma.c: Drop space after unary `!`
Change-Id: I72f75f3df50af362874818f2c1883a6a1c741087 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/46691/5
Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46691 )
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
Patch Set 5: Code-Review+1
Easy review
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46691 )
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46691 )
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46691 )
Change subject: nb/intel/haswell/gma.c: Drop space after unary `!` ......................................................................
nb/intel/haswell/gma.c: Drop space after unary `!`
Change-Id: I72f75f3df50af362874818f2c1883a6a1c741087 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46691 Reviewed-by: Swift Geek (Sebastian Grzywna) swiftgeek@gmail.com Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Swift Geek (Sebastian Grzywna): Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index dc7b629..989d100 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -485,7 +485,7 @@ } }
- if (! lightup_ok) { + if (!lightup_ok) { printk(BIOS_SPEW, "FUI did not run; using VBIOS\n"); mdelay(CONFIG_PRE_GRAPHICS_DELAY); pci_dev_init(dev);