Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69526 )
Change subject: mb/aopen/dxplplusu: Iterate CPUs for ACPI MADT ......................................................................
mb/aopen/dxplplusu: Iterate CPUs for ACPI MADT
Change-Id: I64e5f5ee59859564c31ebb6f73b91d3d36be7d77 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69526 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/aopen/dxplplusu/acpi_tables.c 1 file changed, 15 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c index 2a3a97e..5f0d943 100644 --- a/src/mainboard/aopen/dxplplusu/acpi_tables.c +++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c @@ -1,10 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-/* - * Ported to Intel XE7501DEVKIT by Agami Aruma - * Ported to AOpen DXPL Plus-U by Kyösti Mälkki - */ - #include <acpi/acpi.h> #include <device/pci_def.h>
@@ -13,11 +8,7 @@ struct device *bdev, *dev = NULL; struct resource *res = NULL;
- /* SJM: Hard-code CPU LAPIC entries for now */ - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, 0, 0); - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, 1, 6); - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, 2, 1); - current += acpi_create_madt_lapic((acpi_madt_lapic_t *)current, 3, 7); + current = acpi_create_madt_lapics(current);
/* Southbridge IOAPIC */ current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, 0xfec00000);