Attention is currently required from: Paul Fagerburg, Jan Dabros.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52938 )
Change subject: tests: Add lib/spd_cache-test test case
......................................................................
Patch Set 3:
(2 comments)
File tests/include/tests/lib/spd_cache_data.h:
https://review.coreboot.org/c/coreboot/+/52938/comment/ba8966f9_d9da15a5
PS2, Line 5: unsigned char spd_data_ddr4_1[] = {
For the record: […]
Done
File tests/lib/spd_cache-test.c:
https://review.coreboot.org/c/coreboot/+/52938/comment/eac2edcf_65cd8b93
PS2, Line 50: static void test_load_spd_cache(void **state)
Yes, this requires some explanation. I will add it in next version.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52938
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9a1420e49e1e80d180117c931e630e54c90cd75
Gerrit-Change-Number: 52938
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Fri, 07 May 2021 11:55:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment