Attention is currently required from: Derek Huang, Dinesh Gehlot, Eric Lai, Felix Held, Kapil Porwal, Leo Chou, Nick Vaccaro, Shou-Chieh Hsu, Subrata Banik.
Roger Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82109?usp=email )
Change subject: mb/google/nissa/variant/pujjoga: Update devicetree settings
......................................................................
Patch Set 4:
(4 comments)
File src/mainboard/google/brya/variants/pujjoga/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/82109/comment/4f6f76a4_65e2b889 :
PS3, Line 298:
missing tab
Done
https://review.coreboot.org/c/coreboot/+/82109/comment/8656980e_04f93a9f :
PS3, Line 299:
missing tab
Done
https://review.coreboot.org/c/coreboot/+/82109/comment/5443df69_13fbfb96 :
PS3, Line 311:
missing tab
Done
https://review.coreboot.org/c/coreboot/+/82109/comment/4cbfd30a_3de9cdd1 :
PS3, Line 312:
missing tab
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82109?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I279f94044a22f25100a44b1abe2ef5fb6d0dd835
Gerrit-Change-Number: 82109
Gerrit-PatchSet: 4
Gerrit-Owner: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 May 2024 01:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Gerrit-MessageType: comment