Attention is currently required from: Martin Roth, Mathew King.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51348 )
Change subject: mb/google/guybrush: Confiure early GPIOs in earliest stage
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/google/guybrush/verstage.c:
PS11:
Maybe split this change into a different CL.
https://review.coreboot.org/c/coreboot/+/51348/comment/5d6a7b07_5de9ec8c
PS11, Line 10: const struct soc_amd_gpio *gpios;
: size_t num_gpios;
Can you move the declaration out of the if block.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9410089592776ffe198901f2de914fd04bdbade
Gerrit-Change-Number: 51348
Gerrit-PatchSet: 11
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Wed, 10 Mar 2021 21:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment