Attention is currently required from: Nico Huber, Subrata Banik, Johnny Lin, Christian Walter, Andrey Petrov, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69509 )
Change subject: Revert "src/arch/x86: Use core apic id to get cpu_index()"
......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/69509/comment/20d3632d_d905f101
PS3, Line 33:
: struct cpu_info *info = cpu_info();
: if (!info)
: return FSP_DEVICE_ERROR;
:
: if (processor_info_buffer == NULL)
: return FSP_INVALID_PARAMETER;
:
: if (processor_number >= get_cpu_count())
: return FSP_NOT_FOUND;
:
: apicid = info->cpu->path.apic.apic_id;
Ah this is wrong. It needs to find the lapic device.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a40156ba275b572d7d1913d8c17c24b4c8f6d78
Gerrit-Change-Number: 69509
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 19:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment