Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Pranava Y N, Rishika Raj.
Subrata Banik has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/83707?usp=email )
Change subject: mb/google/brya/var/nova: Remove USB Type-C port setting ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/nova/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83707/comment/a039b8f6_dd754e5c?usp... : PS2, Line 282: register "desc" = ""USB2 Type-C Port C0 (MLB)"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "use_custom_pld" = "true" : register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, CENTER, ACPI_PLD_GROUP(1, 0))" I would still call this as USB-C as per product spec
https://www.avocor.com/wp-content/uploads/2023/03/Google_Meet_Series_One_Des...
``` Docking mode (USB-C) - Power delivery @ 45W - Extend laptop to Desk 27 (up to 1440p) - Camera, TrueVoice audio and touchscreen are accessible to laptop ```
As USB2 genesys hub is an internal logic hence better we don't call it and please keep PLD as there is a physical port located on this device ?