Attention is currently required from: Martin Roth, Maximilian Brune, Philipp Hug, ron minnich.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81425?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/arch/riscv/Kconfig:
https://review.coreboot.org/c/coreboot/+/81425/comment/ca0f0e46_03203c0a :
PS1, Line 112:
: # Newer SoC have the menvconfig register.
: # Very few SOC do not have this.
: # Older SoC, such as the SiFive FU[57]40, that
: # do not have this register, should set this
: # to n.
Typically I'd suggest that this text go into a "help" section, but there's no prompt here, so I'm not sure whether or not it matters.
Anyone else have an opinion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81425?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ea302a5acd98f6941bf314da89dd003ab20b596
Gerrit-Change-Number: 81425
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@tinkermill.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@tinkermill.org
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 22 Mar 2024 18:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment