HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32566
Change subject: {src,util}: Remove duplicated includes ......................................................................
{src,util}: Remove duplicated includes
Change-Id: Id09cec6b2aae58b131b208e96fec539d068ff68a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/sandybridge/raminit_common.c M util/cbmem/cbmem.c M util/ectool/ectool.c M util/romcc/romcc.c 4 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/32566/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index cbbd231..5347c5c 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -23,7 +23,7 @@ #include <northbridge/intel/sandybridge/chip.h> #include <device/pci_def.h> #include <delay.h> -#include <arch/cpu.h> + #include "raminit_native.h" #include "raminit_common.h" #include "sandybridge.h" diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index ae1d212..52fdc9b 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -19,7 +19,6 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> -#include <inttypes.h> #include <getopt.h> #include <dirent.h> #include <errno.h> diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index bc3d46c..2af45c3 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -22,7 +22,6 @@ #include <sys/io.h> #endif #include <ec.h> -#include <stdlib.h>
#if defined __NetBSD__ || defined __OpenBSD__
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 4cb2aad..43be171 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -16,7 +16,6 @@ #include <sys/stat.h> #include <fcntl.h> #include <unistd.h> -#include <stdio.h> #include <string.h> #include <limits.h> #include <locale.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32566 )
Change subject: {src,util}: Remove duplicated includes ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/32566/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/#/c/32566/1/src/northbridge/intel/sandybridge/ra... PS1, Line 20: duplicated
https://review.coreboot.org/#/c/32566/1/util/cbmem/cbmem.c File util/cbmem/cbmem.c:
https://review.coreboot.org/#/c/32566/1/util/cbmem/cbmem.c@a17 PS1, Line 17: duplicated
https://review.coreboot.org/#/c/32566/1/util/ectool/ectool.c File util/ectool/ectool.c:
https://review.coreboot.org/#/c/32566/1/util/ectool/ectool.c@a18 PS1, Line 18: duplicated
https://review.coreboot.org/#/c/32566/1/util/romcc/romcc.c File util/romcc/romcc.c:
https://review.coreboot.org/#/c/32566/1/util/romcc/romcc.c@a14 PS1, Line 14: duplicated
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32566 )
Change subject: {src,util}: Remove duplicated includes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32566 )
Change subject: {src,util}: Remove duplicated includes ......................................................................
{src,util}: Remove duplicated includes
Change-Id: Id09cec6b2aae58b131b208e96fec539d068ff68a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32566 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/intel/sandybridge/raminit_common.c M util/cbmem/cbmem.c M util/ectool/ectool.c M util/romcc/romcc.c 4 files changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index cbbd231..5347c5c 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -23,7 +23,7 @@ #include <northbridge/intel/sandybridge/chip.h> #include <device/pci_def.h> #include <delay.h> -#include <arch/cpu.h> + #include "raminit_native.h" #include "raminit_common.h" #include "sandybridge.h" diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index ae1d212..52fdc9b 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -19,7 +19,6 @@ #include <stdlib.h> #include <string.h> #include <unistd.h> -#include <inttypes.h> #include <getopt.h> #include <dirent.h> #include <errno.h> diff --git a/util/ectool/ectool.c b/util/ectool/ectool.c index bc3d46c..2af45c3 100644 --- a/util/ectool/ectool.c +++ b/util/ectool/ectool.c @@ -22,7 +22,6 @@ #include <sys/io.h> #endif #include <ec.h> -#include <stdlib.h>
#if defined __NetBSD__ || defined __OpenBSD__
diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c index 4cb2aad..43be171 100644 --- a/util/romcc/romcc.c +++ b/util/romcc/romcc.c @@ -16,7 +16,6 @@ #include <sys/stat.h> #include <fcntl.h> #include <unistd.h> -#include <stdio.h> #include <string.h> #include <limits.h> #include <locale.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)