Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37871 )
Change subject: soc/intel/common/block: Enable PMC IPC driver
......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37871/16/src/soc/intel/common/block...
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/37871/16/src/soc/intel/common/block...
PS16, Line 46: #define PMC_IPC_USBC_CMD_ID 0xA7
unused?
Used in early TCSS
https://review.coreboot.org/c/coreboot/+/37871/16/src/soc/intel/common/block...
PS16, Line 610: check_ips_sts
nit. Typo? check_ipc_sts. Also should it be pmc_check_ipc_sts for consistency.
this is what it was on the internal patch so I kept it...but it should be ipc you are right I'll update
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd3ed262fc700ccc891ec68997a108f5bfbaf9ed
Gerrit-Change-Number: 37871
Gerrit-PatchSet: 16
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Fri, 07 Feb 2020 19:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-MessageType: comment