Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, David Hendricks, Stefan Reinauer, Angel Pons, Subrata Banik.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52047 )
Change subject: src/acpi: Add initial support for HMAT
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/52047/comment/cc481616_7903fe84
PS5, Line 242: u8 min_transfer_size;
this has a slightly odd definition, a comment may be helpful
https://review.coreboot.org/c/coreboot/+/52047/comment/bdaed25b_43a14b50
PS5, Line 261: u32 cache_attributes
Some `enum`s or `#define` values could be useful to describe this bitfield
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ee60ff990c3cea799c5cbdf7eead818b1bb4f9b
Gerrit-Change-Number: 52047
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 03 May 2021 21:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment