Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Andrey Petrov, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52894 )
Change subject: include/console: Fix FSP Notify phase postcodes discrepancy
......................................................................
Patch Set 2:
(3 comments)
File src/include/console/post_codes.h:
https://review.coreboot.org/c/coreboot/+/52894/comment/804ffb9b_63f20d3f
PS1, Line 209: phase
Probably say "(end of firmware)" after phase? Same for after call?
Ack
https://review.coreboot.org/c/coreboot/+/52894/comment/a98fe577_da027211
PS1, Line 256: before
This seems to have the same problem.
Ack
https://review.coreboot.org/c/coreboot/+/52894/comment/9e7fb7d7_3011f0f5
PS1, Line 260: POST_FSP_NOTIFY_BEFORE_FINALIZE
Just noticed that we are incorrectly using this even after finalize notification is done: https://re […]
https://review.coreboot.org/c/coreboot/+/52894/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52894
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c825d5f1f31f80ad2a03ff5d6006daa7104d23
Gerrit-Change-Number: 52894
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 04 May 2021 18:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment