Attention is currently required from: Nico Huber, Tim Wawrzynczak, Ravindra, Subrata Banik, Michael Niewöhner, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59359 )
Change subject: soc/intel/common: Implement ACPI CPPCv3 package to support hybrid core ......................................................................
Patch Set 2:
(5 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134191): https://review.coreboot.org/c/coreboot/+/59359/comment/56ba133e_450e0ab9 PS2, Line 91: (uint16_t)((max_non_turbo_ratio * big_core_scal_factor) /100); need consistent spacing around '/' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134191): https://review.coreboot.org/c/coreboot/+/59359/comment/859060c7_e7930010 PS2, Line 109: * If Nominal Frequency is supported, update Nominal Frequency and set core's Nominal line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134191): https://review.coreboot.org/c/coreboot/+/59359/comment/6c656747_9c242ff3 PS2, Line 113: acpigen_set_package_element_int(CPPC_PACKAGE_NAME, 22, cpu_hybrid_info.nominal_freq); line over 96 characters
File src/soc/intel/common/block/include/intelblocks/acpi.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134191): https://review.coreboot.org/c/coreboot/+/59359/comment/8ec6a038_548b4e1e PS2, Line 17: uint16_t *small_core_scal_factor); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134191): https://review.coreboot.org/c/coreboot/+/59359/comment/88561e20_317e7ad8 PS2, Line 17: uint16_t *small_core_scal_factor); please, no spaces at the start of a line