Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Ren Kuo, Tyler Wang, Nick Vaccaro, Eric Lai.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 )
Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164351):
https://review.coreboot.org/c/coreboot/+/69693/comment/9441ad7d_d52855c0
PS7, Line 12: 2. Modfiy fw_config gpio table to skip the LTE and WFC from craask.
'Modfiy' may be misspelled - perhaps 'Modify'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5
Gerrit-Change-Number: 69693
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 03:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment