Attention is currently required from: Xixi Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format
......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5:
src/soc/mediatek/common/emi. […]
Oops, I didn't even see it you use it for this as well. Let me factor out a function to get the total size, that sounds useful.
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/68871/comment/b07514d7_a50f881f
PS5, Line 16: 0
nit: current version is located at the reserve[1] in the old format, so actually we can't identify i […]
Yes, I was not trying to make it distinguishable from what the format was before this patch. That format didn't ship anywhere so we can just pretend it never existed.
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/68871/comment/d2a92dc3_7383d01d
PS3, Line 129: ddr->mrr_info.mr8_density[r]
Then I guess we'd have to convert it to megabits here.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If34e6857439b6f6ab225344e5b4dd0ff11d8d42a
Gerrit-Change-Number: 68871
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: Xi Chen
xixi.chen@mediatek.com
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 23:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment