[M] Change in coreboot[main]: mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic - coreboot-gerrit

2 Nov 2023

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78873?usp=email )
Change subject: mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic
......................................................................
mb/google/brya/var/*: Set dGPU/LAN/WLAN device type to generic
Change the dGPU/LAN/WiFi device types from PCI to generic, so that the
bogus PCI device and function values don't end up in coreboot's
internal device tree. The presence of these bogus PCI devices cause the
LPI constraint generator to create does a reference for an ACPI device
which does not exist (SB.PCI0.RP{xx}.MCHC). The invalid reference(s)
cause a Windows BSOD (INTERNAL_POWER_ERROR).
TEST=untested
Change-Id: Ic997b5ad893853b99ae53a2e5c7acf58467ea4f1
Signed-off-by: Matt DeVillier matt.devillier@gmail.com
---
M src/mainboard/google/brya/variants/agah/overridetree.cb
M src/mainboard/google/brya/variants/aurash/overridetree.cb
M src/mainboard/google/brya/variants/brask/overridetree.cb
M src/mainboard/google/brya/variants/constitution/overridetree.cb
M src/mainboard/google/brya/variants/gaelin/overridetree.cb
M src/mainboard/google/brya/variants/gladios/overridetree.cb
M src/mainboard/google/brya/variants/gothrax/overridetree.cb
M src/mainboard/google/brya/variants/hades/overridetree.cb
M src/mainboard/google/brya/variants/joxer/overridetree.cb
M src/mainboard/google/brya/variants/kinox/overridetree.cb
M src/mainboard/google/brya/variants/kuldax/overridetree.cb
M src/mainboard/google/brya/variants/lisbon/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/moli/overridetree.cb
M src/mainboard/google/brya/variants/nereid/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/pujjo/overridetree.cb
M src/mainboard/google/brya/variants/quandiso/overridetree.cb
M src/mainboard/google/brya/variants/xivu/overridetree.cb
M src/mainboard/google/brya/variants/yaviks/overridetree.cb
M src/mainboard/google/brya/variants/yavilla/overridetree.cb
21 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/78873/1

diff --git a/src/mainboard/google/brya/variants/agah/overridetree.cb b/src/mainboard/google/brya/variants/agah/overridetree.cb
index 52b9fcd..7bea703 100644
--- a/src/mainboard/google/brya/variants/agah/overridetree.cb
+++ b/src/mainboard/google/brya/variants/agah/overridetree.cb
@@ -88,7 +88,7 @@
    			.clk_src = 0,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
-			device pci 00.0 alias dgpu on end
+			device generic 0 alias dgpu on end
    	end
    	device ref dtt on
    		chip drivers/intel/dptf
@@ -232,7 +232,7 @@
    			register "wake" = "GPE0_DW0_07"
    			register "device_index" = "0"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end 	#RTL8111H Ethernet NIC
    	device ref pcie_rp4 off end
diff --git a/src/mainboard/google/brya/variants/aurash/overridetree.cb b/src/mainboard/google/brya/variants/aurash/overridetree.cb
index 2b9ebfe..09f7c66 100644
--- a/src/mainboard/google/brya/variants/aurash/overridetree.cb
+++ b/src/mainboard/google/brya/variants/aurash/overridetree.cb
@@ -163,7 +163,7 @@
    			.clk_req = 4,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
-			device pci 00.0 on end
+			device generic 0 on end
    	end # IntelI225V Ethernet NIC
    	device ref pcie_rp7 on
    		chip drivers/net
@@ -171,7 +171,7 @@
    			register "wake" = "GPE0_DW0_07"
    			register "device_index" = "0"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8111K Ethernet NIC
    	device ref pcie_rp8  off end        #pcie_rp    8  Empty
diff --git a/src/mainboard/google/brya/variants/brask/overridetree.cb b/src/mainboard/google/brya/variants/brask/overridetree.cb
index 995f20c..a8393b4 100644
--- a/src/mainboard/google/brya/variants/brask/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brask/overridetree.cb
@@ -78,7 +78,7 @@
    			register "customized_led2" = "0x028"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8125 Ethernet NIC
    	device ref pcie4_0 on
diff --git a/src/mainboard/google/brya/variants/constitution/overridetree.cb b/src/mainboard/google/brya/variants/constitution/overridetree.cb
index c6083f1..41d5022 100644
--- a/src/mainboard/google/brya/variants/constitution/overridetree.cb
+++ b/src/mainboard/google/brya/variants/constitution/overridetree.cb
@@ -181,7 +181,7 @@
    			register "customized_led2" = "0x028"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8125 Ethernet NIC
    	device ref pcie_rp8 on
diff --git a/src/mainboard/google/brya/variants/gaelin/overridetree.cb b/src/mainboard/google/brya/variants/gaelin/overridetree.cb
index b3af7c1..d198530 100644
--- a/src/mainboard/google/brya/variants/gaelin/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gaelin/overridetree.cb
@@ -230,7 +230,7 @@
    			register "customized_leds" = "0x0843"
    			register "wake" = "GPE0_DW0_07" #GPP_A7
    			register "device_index" = "0"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end #PCIE7 RTL8111K Ethernet NIC
    	device ref pcie_rp8 off end
diff --git a/src/mainboard/google/brya/variants/gladios/overridetree.cb b/src/mainboard/google/brya/variants/gladios/overridetree.cb
index 6a21f2a..0aa0e75 100644
--- a/src/mainboard/google/brya/variants/gladios/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gladios/overridetree.cb
@@ -190,7 +190,7 @@
    			register "customized_leds" = "0x060f"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8111 Ethernet NIC
    	device ref pcie_rp8 on
diff --git a/src/mainboard/google/brya/variants/gothrax/overridetree.cb b/src/mainboard/google/brya/variants/gothrax/overridetree.cb
index 87a2b48..e51c1fb 100644
--- a/src/mainboard/google/brya/variants/gothrax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gothrax/overridetree.cb
@@ -330,7 +330,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 on
diff --git a/src/mainboard/google/brya/variants/hades/overridetree.cb b/src/mainboard/google/brya/variants/hades/overridetree.cb
index b8a69a0..53ef892 100644
--- a/src/mainboard/google/brya/variants/hades/overridetree.cb
+++ b/src/mainboard/google/brya/variants/hades/overridetree.cb
@@ -78,7 +78,7 @@
    			.clk_src = 0,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
-			device pci 00.0 alias dgpu on end
+			device generic 0 alias dgpu on end
    	end
    	device ref dtt on
    		chip drivers/intel/dptf
@@ -239,7 +239,7 @@
    			register "wake" = "GPE0_DW0_07"
    			register "device_index" = "0"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end 	#RTL8111H Ethernet NIC
    	device ref pcie_rp9 on
diff --git a/src/mainboard/google/brya/variants/joxer/overridetree.cb b/src/mainboard/google/brya/variants/joxer/overridetree.cb
index 187afe5..cfa022c 100644
--- a/src/mainboard/google/brya/variants/joxer/overridetree.cb
+++ b/src/mainboard/google/brya/variants/joxer/overridetree.cb
@@ -326,7 +326,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 off end # PCIE7 no SD card
diff --git a/src/mainboard/google/brya/variants/kinox/overridetree.cb b/src/mainboard/google/brya/variants/kinox/overridetree.cb
index fcca3d8..71d0e27 100644
--- a/src/mainboard/google/brya/variants/kinox/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kinox/overridetree.cb
@@ -247,7 +247,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    		chip soc/intel/common/block/pcie/rtd3
    			register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B11)"
@@ -278,7 +278,7 @@
    			register "wake" = "GPE0_DW0_07" #GPP_A7
    			register "device_index" = "0"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8111K Ethernet NIC
    	device ref pcie_rp8 off end
diff --git a/src/mainboard/google/brya/variants/kuldax/overridetree.cb b/src/mainboard/google/brya/variants/kuldax/overridetree.cb
index a6adecf..6db03ac 100644
--- a/src/mainboard/google/brya/variants/kuldax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kuldax/overridetree.cb
@@ -207,7 +207,7 @@
    			register "customized_led2" = "0x028"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8125 and RTL8111K Ethernet NIC
    	device ref pcie_rp8 on
diff --git a/src/mainboard/google/brya/variants/lisbon/overridetree.cb b/src/mainboard/google/brya/variants/lisbon/overridetree.cb
index 6a21f2a..0aa0e75 100644
--- a/src/mainboard/google/brya/variants/lisbon/overridetree.cb
+++ b/src/mainboard/google/brya/variants/lisbon/overridetree.cb
@@ -190,7 +190,7 @@
    			register "customized_leds" = "0x060f"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8111 Ethernet NIC
    	device ref pcie_rp8 on
diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb
index 7fd0ef1..311971f 100644
--- a/src/mainboard/google/brya/variants/marasov/overridetree.cb
+++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb
@@ -318,7 +318,7 @@
    		}"
    		chip drivers/wifi/generic
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp8 off end
diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb
index e636540..5397463 100644
--- a/src/mainboard/google/brya/variants/moli/overridetree.cb
+++ b/src/mainboard/google/brya/variants/moli/overridetree.cb
@@ -164,7 +164,7 @@
    			.clk_req = 4,
    			.flags = PCIE_RP_LTR | PCIE_RP_AER,
    		}"
-			device pci 00.0 on end
+			device generic 0 on end
    	end # IntelI225V Ethernet NIC
    	device ref pcie_rp7 on
    		chip drivers/net
@@ -172,7 +172,7 @@
    			register "wake" = "GPE0_DW0_07"
    			register "device_index" = "0"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end # RTL8111K Ethernet NIC
    	device ref pcie_rp8 on
diff --git a/src/mainboard/google/brya/variants/nereid/overridetree.cb b/src/mainboard/google/brya/variants/nereid/overridetree.cb
index 9d9b871..5de5c1b 100644
--- a/src/mainboard/google/brya/variants/nereid/overridetree.cb
+++ b/src/mainboard/google/brya/variants/nereid/overridetree.cb
@@ -209,7 +209,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pch_espi on
diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb
index 650d508..5ba725b 100644
--- a/src/mainboard/google/brya/variants/osiris/overridetree.cb
+++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb
@@ -281,7 +281,7 @@
    			register "customized_led2" = "0x028"
    			register "enable_aspm_l1_2" = "1"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    		# Enable PCIE 7 using clk 6
    		register "pch_pcie_rp[PCH_RP(7)]" = "{
diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb
index 51383e0..59ab871 100644
--- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb
+++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb
@@ -673,7 +673,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 on
diff --git a/src/mainboard/google/brya/variants/quandiso/overridetree.cb b/src/mainboard/google/brya/variants/quandiso/overridetree.cb
index e94d3da..64cd862 100644
--- a/src/mainboard/google/brya/variants/quandiso/overridetree.cb
+++ b/src/mainboard/google/brya/variants/quandiso/overridetree.cb
@@ -398,7 +398,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 on
diff --git a/src/mainboard/google/brya/variants/xivu/overridetree.cb b/src/mainboard/google/brya/variants/xivu/overridetree.cb
index be4d8df..2e781a2 100644
--- a/src/mainboard/google/brya/variants/xivu/overridetree.cb
+++ b/src/mainboard/google/brya/variants/xivu/overridetree.cb
@@ -376,7 +376,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
diff --git a/src/mainboard/google/brya/variants/yaviks/overridetree.cb b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
index 308ed10..580181c 100644
--- a/src/mainboard/google/brya/variants/yaviks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yaviks/overridetree.cb
@@ -450,7 +450,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 on
diff --git a/src/mainboard/google/brya/variants/yavilla/overridetree.cb b/src/mainboard/google/brya/variants/yavilla/overridetree.cb
index ee5a3b6..4a96742 100644
--- a/src/mainboard/google/brya/variants/yavilla/overridetree.cb
+++ b/src/mainboard/google/brya/variants/yavilla/overridetree.cb
@@ -496,7 +496,7 @@
    		chip drivers/wifi/generic
    			register "wake" = "GPE0_DW1_03"
    			register "add_acpi_dma_property" = "true"
-				device pci 00.0 on end
+				device generic 0 on end
    		end
    	end
    	device ref pcie_rp7 off end #PCIE7 no SD card
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/78873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic997b5ad893853b99ae53a2e5c7acf58467ea4f1
Gerrit-Change-Number: 78873
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-MessageType: newchange



    