Change in ...coreboot[master]: sb/intel/common/fw: Make make aware that it needs binaries
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33327
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
sb/intel/common/fw: Make make aware that it needs binaries
Change-Id: I40c3979b84341cb88c7e9a5084c1a97230ea5503 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/southbridge/intel/common/firmware/Makefile.inc 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33327/1
diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc index 898ab60..eb23847 100644 --- a/src/southbridge/intel/common/firmware/Makefile.inc +++ b/src/southbridge/intel/common/firmware/Makefile.inc @@ -31,6 +31,16 @@ IFDTOOL_USE_CHIPSET := -p $(CONFIG_IFD_CHIPSET) endif
+add_intel_firmware: $(CONFIG_IFD_BIN_PATH) +ifeq ($(CONFIG_HAVE_ME_BIN),y) +add_intel_firmware: $(CONFIG_ME_BIN_PATH) +endif +ifeq ($(CONFIG_HAVE_GBE_BIN),y) +add_intel_firmware: $(CONFIG_GBE_BIN_PATH) +endif +ifeq ($(CONFIG_HAVE_EC_BIN),y) +add_intel_firmware: $(CONFIG_EC_BIN_PATH) +endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) printf " DD Adding Intel Firmware Descriptor\n" dd if=$(IFD_BIN_PATH) \
Hello Angel Pons, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33327
to look at the new patch set (#2).
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
sb/intel/common/fw: Make make aware that it needs binaries
As we redirect all `dd` output to /dev/null (it would clutter the console otherwise), there is no error message if a binary to be added isn't found. If we add them as dependency, OTOH, `make` will complain properly.
Change-Id: I40c3979b84341cb88c7e9a5084c1a97230ea5503 Signed-off-by: Nico Huber nico.h@gmx.de --- M src/southbridge/intel/common/firmware/Makefile.inc 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/33327/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33327 )
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33327 )
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
Patch Set 3:
How does this exactly work?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33327 )
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
Patch Set 3: Code-Review+2
Patch Set 3:
How does this exactly work?
Ah wait, I see it now: just adding the paths to the binaries to be included as dependencies to the `add_intel_firmware` rule. It would seem I am still a bit asleep.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33327 )
Change subject: sb/intel/common/fw: Make make aware that it needs binaries ......................................................................
sb/intel/common/fw: Make make aware that it needs binaries
As we redirect all `dd` output to /dev/null (it would clutter the console otherwise), there is no error message if a binary to be added isn't found. If we add them as dependency, OTOH, `make` will complain properly.
Change-Id: I40c3979b84341cb88c7e9a5084c1a97230ea5503 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/33327 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/common/firmware/Makefile.inc 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.inc index 898ab60..e706036 100644 --- a/src/southbridge/intel/common/firmware/Makefile.inc +++ b/src/southbridge/intel/common/firmware/Makefile.inc @@ -31,6 +31,16 @@ IFDTOOL_USE_CHIPSET := -p $(CONFIG_IFD_CHIPSET) endif
+add_intel_firmware: $(call strip_quotes,$(CONFIG_IFD_BIN_PATH)) +ifeq ($(CONFIG_HAVE_ME_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_ME_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_GBE_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_GBE_BIN_PATH)) +endif +ifeq ($(CONFIG_HAVE_EC_BIN),y) +add_intel_firmware: $(call strip_quotes,$(CONFIG_EC_BIN_PATH)) +endif add_intel_firmware: $(obj)/coreboot.pre $(IFDTOOL) printf " DD Adding Intel Firmware Descriptor\n" dd if=$(IFD_BIN_PATH) \
-
Angel Pons (Code Review) -
Nico Huber (Code Review)