Attention is currently required from: Martin Roth. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52375 )
Change subject: sc7280: Add PCIe Root Complex driver in coreboot ......................................................................
Patch Set 2:
(60 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/a97970b0_8ea88b18 PS2, Line 65: #define PCIE1_IO_ADDR 0x40200000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/bbe53691_579ab26d PS2, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/c273156e_16e6d40a PS2, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/e58120c8_bf8b4673 PS2, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/a008ce93_a93a80a4 PS2, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/c569da67_60e98be6 PS2, Line 12: #define GPIO_PERST 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/9ef78864_6c080a75 PS2, Line 14: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/47d675b4_348af714 PS2, Line 14: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/802024af_b723dd36 PS2, Line 94: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/13aff0a8_edb11ce7 PS2, Line 106: #define PCIE_BUS_CFG(pri,sec,sub) ((sub & 0xFF)<<16|(sec & 0xFF)<<8|(pri&0xFF)) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/9c6daab9_0c98965c PS2, Line 106: #define PCIE_BUS_CFG(pri,sec,sub) ((sub & 0xFF)<<16|(sec & 0xFF)<<8|(pri&0xFF)) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/ac694e59_8a0b4174 PS2, Line 215: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/6f6a47ef_edd48a8a PS2, Line 216: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/109c98ae_e2033e09 PS2, Line 217: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/00f3cdb4_6de84797 PS2, Line 218: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/942a0a00_53426773 PS2, Line 230: unsigned int offset; please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/include/soc/qcom_qmp_phy.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/2cb0ec1e_c367d789 PS2, Line 61: #define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_TX 0x3c please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/4dee8814_584525d8 PS2, Line 62: #define QSERDES_V4_TX_RES_CODE_LANE_OFFSET_RX 0x40 please, no space before tabs
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/d20831ea_3435ae20 PS2, Line 89: }qmp_phy_cfg_t; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/d28a20cf_5ed3153a PS2, Line 249: .qmp_phy_base = (void *) PCIE_1_QMP_PHY, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/4f1133ed_36b25b41 PS2, Line 250: .serdes = (void *) PCE1_QPHY_SERDES, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/95faf68d_816f41c2 PS2, Line 251: .tx0 = (void *) PCE1_QPHY_TX0, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/4e3014fc_a8bc5ee9 PS2, Line 252: .rx0 = (void *) PCE1_QPHY_RX0, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/e04cc6e0_b406c300 PS2, Line 253: .pcs = (void *) PCIE1_QMP_PHY_PCS_COM, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/d9e8a104_0d90db69 PS2, Line 254: .tx1 = (void *) PCE1_QPHY_TX1, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/ec2777be_dc93799b PS2, Line 255: .rx1 = (void *) PCE1_QPHY_RX1, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/c37d41c6_dffb301d PS2, Line 256: .pcs_misc = (void *) PCE1_QPHY_PCS_MISC, please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/5162cbc2_3029b950 PS2, Line 270: .pcs_tbl_num_sec= ARRAY_SIZE(sc7280_qmp_gen3x2_pcie_pcs_tbl), spaces required around that '=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/9c83bbe5_8a618e1a PS2, Line 272: .pcs_misc_tbl_num= ARRAY_SIZE(sc7280_qmp_pcie_pcs_misc_tbl), spaces required around that '=' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/be2b607e_bb78f9ea PS2, Line 444: printk(BIOS_INFO, "PCIE1: Assert the reset of EP \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/cf9473be_bc0758de PS2, Line 676: if (!bar_response) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/e77b9941_1ee894b1 PS2, Line 902: const struct qcom_qmp_phy_init_tbl tbl[], int num, uint8_t ln_mask) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/9f106053_7569e583 PS2, Line 902: const struct qcom_qmp_phy_init_tbl tbl[], int num, uint8_t ln_mask) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/47097400_a73c970d PS2, Line 908: if (!(t->lane_mask & ln_mask)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/961d39b7_6a3517c3 PS2, Line 966: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/db8150fe_de931003 PS2, Line 969: if (ret) { suspect code indent for conditional statements (8, 13)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/37ca37b3_0588a575 PS2, Line 970: printk(BIOS_ERR, " %s(): Pipe clock enable failed\n", __func__); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/5f8b2a06_70852895 PS2, Line 971: return -1; Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/6f8f83fa_c7909087 PS2, Line 989: pcie_rc_config_t *pcierc = pcie->rc_cfg; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/2ee791ce_4cc9b244 PS2, Line 989: pcie_rc_config_t *pcierc = pcie->rc_cfg; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/f4d9851d_d1b74d04 PS2, Line 990: uint64_t ep_config_base, ep_config_size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/e3b4852a_218faeb0 PS2, Line 990: uint64_t ep_config_base, ep_config_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/60df3e95_37281fbb PS2, Line 992: ep_config_base = (uint64_t)pcierc->cfg_base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/c7c3ff1d_5d08c917 PS2, Line 992: ep_config_base = (uint64_t)pcierc->cfg_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/4e49652a_e4ece108 PS2, Line 993: ep_config_size = pcierc->cfg_size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/347bca55_667c7747 PS2, Line 993: ep_config_size = pcierc->cfg_size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/b703df4c_7094f535 PS2, Line 996: qcom_dw_pcie_prog_outbound_atu(pcie, PCIE_ATU_REGION_INDEX1, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/f04babe1_ed223b42 PS2, Line 996: qcom_dw_pcie_prog_outbound_atu(pcie, PCIE_ATU_REGION_INDEX1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/d092ff98_29bba521 PS2, Line 997: PCIE_ATU_TYPE_CFG0, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/0126f9b5_54e3cd32 PS2, Line 997: PCIE_ATU_TYPE_CFG0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/167cbdfc_ce32b6a2 PS2, Line 998: ep_config_base, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/ee66183e_b22efc5e PS2, Line 998: ep_config_base, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/ec541965_00afc54b PS2, Line 999: (1 << 24), ep_config_size); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/688bf23d_1311508d PS2, Line 999: (1 << 24), ep_config_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/7cdc3244_905342cb PS2, Line 999: (1 << 24), ep_config_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/828d1ad3_b3e2ec0b PS2, Line 1057: for (clk = PCIE_1_SLV_Q2A_AXI_CLK; clk < PCIE_CLK_COUNT - 3; clk ++) { space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/d1c57c95_95a9844b PS2, Line 1064: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/f74c381e_8dea62a8 PS2, Line 1092: if(ret) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/ce5bb3b5_fe6774cf PS2, Line 1126: if(!ret) { space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117224): https://review.coreboot.org/c/coreboot/+/52375/comment/900ac83c_f4f6a015 PS2, Line 1126: if(!ret) { braces {} are not necessary for any arm of this statement
-
build bot (Jenkins) (Code Review)