Change in coreboot[master]: console/flashsconsole: Add spi flash console for debugging - coreboot-gerrit

30 May 2017


      Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/19849 )
Change subject: console/flashsconsole: Add spi flash console for debugging
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/19849/11/src/drivers/spi/flashconsole.c
File src/drivers/spi/flashconsole.c:
Line 102: 	line_buffer[len++] = c;
...
Ah. Sorry. I misread the flow and completely missed that you were checking
Np! Thanks for the review :)
-- 
To view, visit https://review.coreboot.org/19849
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74a297b94f6881d8c27cbe5168f161d8331c3df3
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Youness Alaoui snifikino@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé philippe.mathieu.daude@gmail.com
Gerrit-Reviewer: Youness Alaoui snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes