Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38824 )
Change subject: soc/intel/apollolake: Display apollolake platform information ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Patch Set 3:
Is there a reason why this needs to be part of bootblock? We have size constrains in bootblock anyway and on the other hand have a plenty of space in the ramstage? Wouldn't it be as useful in ramstage?
good point, right now its more over parity with other soc design we have where bootblock does report platform early.
But fare point to move those in romstage may be as these are sorts of information to have, nothing as such mandatory to have inside BB itself. Agree ?
Sure, romstage is OK as well OFC. I just stumbled across this issue as the bootblock size was increased and I do not see a good reason for it in this context.
yeah make sense.
@Usha, possible for you to test this CL moving report platform into romstage ?
Also how about 1 dedicated CL for rest of IA-SoC to move report platform into romstage.
Once sorted we can create common report_platform.c for all SOC and use it from romstage?
Yes Subrata, this can be done. I will test this CL by moving it into romstage and update.