Attention is currently required from: Stefan Ott, Evgeny Zinoviev, Alexander Couzens, Elyes Haouas.
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70111 )
Change subject: sb/intel: Use boolean for docking_supported
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
File src/southbridge/intel/bd82x6x/chip.h:
https://review.coreboot.org/c/coreboot/+/70111/comment/6827b80f_a0208f64
PS4, Line 66: bool docking_supported:false;
'bool' type doesn't have bitfield (besides, a bitfield of length '0' is odd...).
So simply "bool docking_supported;" here?
File src/southbridge/intel/i82801gx/chip.h:
https://review.coreboot.org/c/coreboot/+/70111/comment/a9a3d1ea_5cceaa69
PS4, Line 67: bool docking_supported:true;
Simply "bool docking_supported;" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1df5a0bd914c11993ce291939f68848bcce0c638
Gerrit-Change-Number: 70111
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Philippe Mathieu-Daudé
f4bug@amsat.org
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Wed, 30 Nov 2022 08:47:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment