Attention is currently required from: Jamie Ryu, Jay Patel, Kapil Porwal, Subrata Banik, Tarun Tuli, Wonkyu Kim.
Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )
Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/rex0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/75525/comment/30b4ac4b_95dcbbff :
PS4, Line 37: ish_enable_pads
GPIOs, mentioned in b/283477280#comment3, are still missing.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75525?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f9a7c8318fa9ae59b6f613eafdacbfa07c749
Gerrit-Change-Number: 75525
Gerrit-PatchSet: 5
Gerrit-Owner: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Jay Patel
jay2.patel@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Comment-Date: Sat, 03 Jun 2023 03:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment