Attention is currently required from: Rizwan Qureshi, Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58513 )
Change subject: soc/intel/common: Check if CSE is function disable
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/58513/comment/e3ef199f_37498494
PS5, Line 182: if (!is_cse_enabled())
Is this the only situation? Any other HECI command need check this?
@Eric, looking at the scope of FSP putting the CSE into FD, EOP is the only command that comes after that. Hence, for now to fix this regression, we could go with this.
But I might need to find a way to reactor the common code in general to nullify the assumption that all PCI devices are available on the PCI bus by default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2046eb19716c397a066c2c41e1b027a256bd6cf9
Gerrit-Change-Number: 58513
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 08:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment