Change in coreboot[master]: soc/amd/common/espi,mb/: Allow configuring open drain ALERT# - coreboot-gerrit

5 May 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Rob Barnes.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52954 )
Change subject: soc/amd/common/espi,mb/: Allow configuring open drain ALERT#
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/52954/comment/58bc0189_04709e6b 
PS3, Line 705: die
does this really need to call die()? i'd assume that this should be a BIOS_ERR and continue; at elast i don't see why we should just just stop booting here
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia35fc59a699cf9444b53aad5c9bb71aa27ce9251
Gerrit-Change-Number: 52954
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 21:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment