Attention is currently required from: Alicja Michalska, Felix Singer, Michał Żygowski, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )
Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H) ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/erying/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80853/comment/cb6dc280_e6002b97 : PS2, Line 197: end Looks like this corresponded to the `device domain 0` entry that was removed, so now it's superfluous, causing the syntax error in the build. It does seem to build if this end line is removed, but I'm not sure if the domain device still needs to be present in the board dt for all the devices under it to work properly, despite it already being on in the chipset dt. The generated static.c files do seem to differ if domain 0 is present in the mb dt vs not, so it does at least make some difference. I'm not super familiar with how this should work, but I'd assume it does need to be present.
-
Nicholas Chin (Code Review)