Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 23:
(6 comments)
https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcp... File src/commonlib/include/commonlib/tcpa_log_serialized.h:
https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcp... PS20, Line 21: #define MAX_TCPA_LOG_ENTRIES 50
This is specific to coreboot proper's implementation and shouldn't necessarily be in here.
Done
https://review.coreboot.org/#/c/29563/20/src/commonlib/include/commonlib/tcp... PS20, Line 26: struct tcpa_entry {
I don't see why this needs to be in the header since it's really dependent on the format string you […]
Done
https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h File src/include/memlayout.h:
https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h@168 PS20, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
Macros with multiple statements should be enclosed in a do - while loop
Done
https://review.coreboot.org/#/c/29563/20/src/include/memlayout.h@168 PS20, Line 168: #define VBOOT2_TPM_LOG(addr, size) \
macros should not use a trailing semicolon
Done
https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c@79 PS20, Line 79: memset(log_string, 0, sizeof(log_string));
This needs to subtract j for proper length calculation.
Done
https://review.coreboot.org/#/c/29563/20/src/security/tpm/tspi/log.c@116 PS20, Line 116: EST_MAX_LENGT
MIN(digest_length, TCPA_DIGEST_MAX_LENGTH)
Done
-
Philipp Deppenwiese (Code Review)