Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49470 )
Change subject: device: Add new Kconfig DGPU_VGA_IS_PRIMARY
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
@Nico if you can help with review ?
It's hard as you never mention if you are referring to a discrete GPU soldered
to the mainboard or a discrete, plugged-in card. You may not know this, but we
don't all have access to your board schematics.
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/49470/comment/948c7575_91f6dcb2
PS1, Line 124: external
: graphics card
This is exactly what the very next option "ONBOARD_VGA_IS_PRIMARY"
is about.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I465541cb45c9022d53a5beb3fff1f80660c357c9
Gerrit-Change-Number: 49470
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 16 Jan 2021 17:34:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment