Attention is currently required from: Alexander Couzens, Alexei Sorokin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80468?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/lenovo/x230: Disable the USB P8 port
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80468/comment/40f41f07_c99bcd40 :
PS4, Line 9: This port is not connected on the X230, X230i, X230t.
According to what source?
https://review.coreboot.org/c/coreboot/+/80468/comment/ad51aef3_7d10ed5c :
PS4, Line 12: was disabled, but after commit 3dc12c1e1918 it has become enabled.
I’d write:
commit 3dc12c1e1918 (bd82x6x: Consolidate early native USB init)
Patchset:
PS4:
Welcome to coreboot, and thank you very much for the contribution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80468?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin
sor.alexei@meowr.ru
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Vladimir Serbinenko
phcoder@gmail.com
Gerrit-Attention: Alexei Sorokin
sor.alexei@meowr.ru
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 14 Feb 2024 15:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment