Attention is currently required from: Alexander Couzens, Alexei Sorokin.
Patch set 4:Code-Review +1
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
View Change
3 comments:
Commit Message:
Patch Set #4, Line 9: This port is not connected on the X230, X230i, X230t.
According to what source?
Patch Set #4, Line 12: was disabled, but after commit 3dc12c1e1918 it has become enabled.
I’d write:
commit 3dc12c1e1918 (bd82x6x: Consolidate early native USB init)
Patchset:
To view, visit change 80468. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I952193798c0894b256b21d9fb3f238074ff5f0f0
Gerrit-Change-Number: 80468
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Sorokin <sor.alexei@meowr.ru>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin L Roth <gaumless@gmail.com>
Gerrit-CC: Vladimir Serbinenko <phcoder@gmail.com>
Gerrit-Attention: Alexei Sorokin <sor.alexei@meowr.ru>
Gerrit-Attention: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Comment-Date: Wed, 14 Feb 2024 15:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment