Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82644?usp=email )
Change subject: acpi/acpi_apic: use generic MADT IRQ override function for SCI override ......................................................................
acpi/acpi_apic: use generic MADT IRQ override function for SCI override
Call acpi_create_madt_irqoverride from acpi_create_madt_sci_override with the correct parameters instead or re-implementing the same functionality.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d Reviewed-on: https://review.coreboot.org/c/coreboot/+/82644 Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/acpi/acpi_apic.c 1 file changed, 1 insertion(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index ebff44f..b47586d 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -130,14 +130,7 @@ if (!CONFIG(ACPI_HAVE_PCAT_8259)) irq = gsi;
- irqoverride->type = IRQ_SOURCE_OVERRIDE; /* Interrupt source override */ - irqoverride->length = sizeof(acpi_madt_irqoverride_t); - irqoverride->bus = MP_BUS_ISA; - irqoverride->source = irq; - irqoverride->gsirq = gsi; - irqoverride->flags = flags; - - return irqoverride->length; + return acpi_create_madt_irqoverride(irqoverride, MP_BUS_ISA, irq, gsi, flags); }
static unsigned long acpi_create_madt_ioapic_gsi0_default(unsigned long current)