Change in coreboot[master]: mb/ocp/deltalake: Override SMBIOS type 2 feature flags

[Tim Chu (Code Review)]

Tim Chu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

mb/ocp/deltalake: Override SMBIOS type 2 feature flags

Override SMBIOS type 2 board feature flags. For Delta Lake, board is
replaceable and is a hosting board.

Tested=Execute "dmidecode -t 2" to check info is correct.

Signed-off-by: Tim Chu 
Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48849/1

diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 72a74da..a6a9739 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -84,6 +84,12 @@
    return slot_id_str;
 }

+u8 smbios_mainboard_feature_flags(void)
+{
+	/* replaceable, hosting board */
+	return 0x9; /* BIT3 + BIT0 */
+}
+
 /*
  * Override SMBIOS type 4 cpu voltage.
  * BIT7 will set to 1 after value return. If BIT7 is set to 1, the remaining seven

[Tim Chu (Code Review)]

Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48849

to look at the new patch set (#2).

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

mb/ocp/deltalake: Override SMBIOS type 2 feature flags

Override SMBIOS type 2 board feature flags. For Delta Lake, board is
replaceable and is a hosting board.

Tested=Execute "dmidecode -t 2" to check info is correct.

Signed-off-by: Tim Chu 
Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48849/2

[Jonathan Zhang (Code Review)]

Attention is currently required from: Jingle Hsu, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/48849/comment/d67e168e_53c7258c 
PS2, Line 91: 	return 0x9; /* BIT3 + BIT0 */
How about adding definitions for mainboard feature flags in src/include/smbios.h? So here we will not need comment and hard coded number.

[Tim Chu (Code Review)]

Attention is currently required from: Jingle Hsu, Tim Chu.
Hello Philipp Deppenwiese, build bot (Jenkins), Anjaneya "Reddy" Chagam, Ryback Hung, Jonathan Zhang, Johnny Lin, Christian Walter, Jingle Hsu, Angel Pons, Morgan Jang, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48849

to look at the new patch set (#3).

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

mb/ocp/deltalake: Override SMBIOS type 2 feature flags

Override SMBIOS type 2 board feature flags. For Delta Lake, board is
replaceable and is a hosting board.

Tested=Execute "dmidecode -t 2" to check info is correct.

Signed-off-by: Tim Chu 
Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382
---
M src/include/smbios.h
M src/mainboard/ocp/deltalake/ramstage.c
2 files changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48849/3

[Tim Chu (Code Review)]

Attention is currently required from: Jonathan Zhang, Jingle Hsu.
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/48849/comment/e95d0ffe_f84681e9 
PS2, Line 91: 	return 0x9; /* BIT3 + BIT0 */
> How about adding definitions for mainboard feature flags in src/include/smbios. […]

Done

[Jonathan Zhang (Code Review)]

Attention is currently required from: Jingle Hsu, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 3: Code-Review+1

[Angel Pons (Code Review)]

Attention is currently required from: Jingle Hsu, Tim Chu.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/48849/comment/97c2faf6_8f527fbf 
PS3, Line 88: +
I would use bitwise OR `|` to combine flags

[Tim Chu (Code Review)]

Attention is currently required from: Jingle Hsu, Tim Chu.
Hello Philipp Deppenwiese, build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Ryback Hung, Johnny Lin, Christian Walter, Jingle Hsu, Angel Pons, Morgan Jang, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48849

to look at the new patch set (#4).

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

mb/ocp/deltalake: Override SMBIOS type 2 feature flags

Override SMBIOS type 2 board feature flags. For Delta Lake, board is
replaceable and is a hosting board.

Tested=Execute "dmidecode -t 2" to check info is correct.

Signed-off-by: Tim Chu 
Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382
---
M src/include/smbios.h
M src/mainboard/ocp/deltalake/ramstage.c
2 files changed, 12 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48849/4

[Tim Chu (Code Review)]

Attention is currently required from: Jingle Hsu, Angel Pons.
Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/ocp/deltalake/ramstage.c:

https://review.coreboot.org/c/coreboot/+/48849/comment/ea9fc58f_2cd62225 
PS3, Line 88: +
> I would use bitwise OR `|` to combine flags

Done

[Jonathan Zhang (Code Review)]

Attention is currently required from: Jingle Hsu, Angel Pons, Tim Chu.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

Patch Set 4: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48849 )

Change subject: mb/ocp/deltalake: Override SMBIOS type 2 feature flags
......................................................................

mb/ocp/deltalake: Override SMBIOS type 2 feature flags

Override SMBIOS type 2 board feature flags. For Delta Lake, board is
replaceable and is a hosting board.

Tested=Execute "dmidecode -t 2" to check info is correct.

Signed-off-by: Tim Chu 
Change-Id: I4469360ec51369dbf8179b3cbac0519ead7f0382
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48849
Tested-by: build bot (Jenkins) 
Reviewed-by: Jonathan Zhang 
---
M src/include/smbios.h
M src/mainboard/ocp/deltalake/ramstage.c
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jonathan Zhang: Looks good to me, approved

diff --git a/src/include/smbios.h b/src/include/smbios.h
index 78f364e..694e091 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -311,6 +311,12 @@
    u8 eos[2];
 } __packed;

+#define SMBIOS_FEATURE_FLAGS_HOSTING_BOARD		(1 << 0)
+#define SMBIOS_FEATURE_FLAGS_REQUIRES_DAUGHTER_CARD	(1 << 1)
+#define SMBIOS_FEATURE_FLAGS_REMOVABLE			(1 << 2)
+#define SMBIOS_FEATURE_FLAGS_REPLACEABLE		(1 << 3)
+#define SMBIOS_FEATURE_FLAGS_HOT_SWAPPABLE		(1 << 4)
+
 typedef enum {
    SMBIOS_BOARD_TYPE_UNKNOWN = 0x01,
    SMBIOS_BOARD_TYPE_OTHER = 0x02,
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index 7c79949..211ba0f 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -56,6 +56,12 @@
    return slot_id_str;
 }

+/* Override SMBIOS type 2 Feature Flags */
+u8 smbios_mainboard_feature_flags(void)
+{
+	return SMBIOS_FEATURE_FLAGS_HOSTING_BOARD | SMBIOS_FEATURE_FLAGS_REPLACEABLE;
+}
+
 /*
  * Override SMBIOS type 4 cpu voltage.
  * BIT7 will set to 1 after value return. If BIT7 is set to 1, the remaining seven