Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69878 )
Change subject: sb/intel/i82801gx: Use "sb/intel/common/tco.h" macros
......................................................................
Patch Set 4:
(1 comment)
File src/southbridge/intel/i82801gx/early_init.c:
https://review.coreboot.org/c/coreboot/+/69878/comment/8a24b96f_a082114f
PS4, Line 74: PMBASE_TCO_OFFSET
as lpc_get_pmbase() will return the pmbase, this should be :
write_pmbase16(TCO1_CNT, TCO_TMR_HLT);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id281a3478051c4876ccbe26452d8744769c86654
Gerrit-Change-Number: 69878
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Nov 2022 08:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment