Change in coreboot[master]: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG
Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38744 )
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG
When acpi_write_dbg2_pci_uart called and no pci uart is available the functions prints "Device not found" as an error. This is not correct.
Change the error level to BIOS_DEBUG so coreboot reports the device is not available but doesn't flag this as an error.
BUG=N/A TEST=build
Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/38744/1
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 2f793b4..6dab373 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -946,7 +946,7 @@ acpi_addr_t address;
if (!dev) { - printk(BIOS_ERR, "%s: Device not found\n", __func__); + printk(BIOS_DEBUG, "%s: Device not found\n", __func__); return current; } if (!dev->enabled) {
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38744 )
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38744 )
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG@9 PS1, Line 9: called is called
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG@10 PS1, Line 10: functions function
Hello Frans Hendriks, Paul Menzel, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38744
to look at the new patch set (#2).
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG
When acpi_write_dbg2_pci_uart called and no pci uart is available the function prints "Device not found" as an error. This is not correct.
Change the error level to BIOS_DEBUG so coreboot reports the device is not available but doesn't flag this as an error.
BUG=N/A TEST=build
Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/38744/2
Hello Frans Hendriks, Paul Menzel, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38744
to look at the new patch set (#3).
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG
When acpi_write_dbg2_pci_uart is called and no pci uart is available the function prints "Device not found" as an error. This is not correct.
Change the error level to BIOS_DEBUG so coreboot reports the device is not available but doesn't flag this as an error.
BUG=N/A TEST=build
Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/38744/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38744 )
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG@9 PS1, Line 9: called
is called
Done
https://review.coreboot.org/c/coreboot/+/38744/1//COMMIT_MSG@10 PS1, Line 10: functions
function
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38744 )
Change subject: arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG ......................................................................
arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG
When acpi_write_dbg2_pci_uart is called and no pci uart is available the function prints "Device not found" as an error. This is not correct.
Change the error level to BIOS_DEBUG so coreboot reports the device is not available but doesn't flag this as an error.
BUG=N/A TEST=build
Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38744 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/arch/x86/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 2f793b4..6dab373 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -946,7 +946,7 @@ acpi_addr_t address;
if (!dev) { - printk(BIOS_ERR, "%s: Device not found\n", __func__); + printk(BIOS_DEBUG, "%s: Device not found\n", __func__); return current; } if (!dev->enabled) {
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)