Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, approved
arch/x86/acpi: Change message in acpi_write_dbg2_pci_uart to BIOS_DEBUG

When acpi_write_dbg2_pci_uart is called and no pci uart is available the
function prints "Device not found" as an error. This is not correct.

Change the error level to BIOS_DEBUG so coreboot reports the device is
not available but doesn't flag this as an error.

BUG=N/A
TEST=build

Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53
Signed-off-by: Wim Vervoorn <wvervoorn@eltan.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38744
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
M src/arch/x86/acpi.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index 2f793b4..6dab373 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -946,7 +946,7 @@
acpi_addr_t address;

if (!dev) {
- printk(BIOS_ERR, "%s: Device not found\n", __func__);
+ printk(BIOS_DEBUG, "%s: Device not found\n", __func__);
return current;
}
if (!dev->enabled) {

To view, visit change 38744. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14567bcfcf5a6ff427e418d15bc2675ae7a28f53
Gerrit-Change-Number: 38744
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks@eltan.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn@eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged