Attention is currently required from: Caveh Jalali, Boris Mittelberg.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69742 )
Change subject: ec/google/chromeec: Fix clang warnings ......................................................................
ec/google/chromeec: Fix clang warnings
Clang warns about structs inside an union also needing the packed attribute.
Change-Id: I8b5233618081db86caedcb2d14870974e109ed9b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/ec/google/chromeec/ec_commands.h 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/69742/1
diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 0bb5db6..c2950da 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -4636,12 +4636,12 @@
struct __ec_todo_unpacked { uint32_t param; /* enum charge_state_param */ - } get_param; + } __ec_todo_packed get_param;
struct __ec_todo_unpacked { uint32_t param; /* param to set */ uint32_t value; /* value to set */ - } set_param; + } __ec_todo_packed set_param ; }; uint8_t chgnum; /* Version 1 supports chgnum */ } __ec_todo_packed;