Change in ...coreboot[master]: mb/t400/acpi: Fix ATPR's buffer length

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

10 May 2019 10 May '19

7:43 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32743

Change subject: mb/t400/acpi: Fix ATPR's buffer length ......................................................................

mb/t400/acpi: Fix ATPR's buffer length

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/1

diff --git a/src/mainboard/lenovo/t400/acpi/graphics.asl b/src/mainboard/lenovo/t400/acpi/graphics.asl index 818ea93..ff6923b 100644 --- a/src/mainboard/lenovo/t400/acpi/graphics.asl +++ b/src/mainboard/lenovo/t400/acpi/graphics.asl @@ -57,15 +57,17 @@

Method (ATPX, 2, Serialized) { /* Create local variables */ - Name (ATPR, Buffer (0x08) { + Name (ATPR, Buffer (0x10) { + 0x0, 0x0, 0x0, 0x0, + 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }) CreateWordField (ATPR, 0x00, SIZE) CreateWordField (ATPR, 0x02, VERS) - CreateDWordField (ATPR, 0x02, MASK) - CreateDWordField (ATPR, 0x04, FUNC) - CreateDWordField (ATPR, 0x06, FLAG) + CreateDWordField (ATPR, 0x04, MASK) + CreateDWordField (ATPR, 0x08, FUNC) + CreateDWordField (ATPR, 0x10, FLAG)

/* Version request */ if (LEqual(Arg0, 0x0))

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

HAOUAS Elyes (Code Review)

10 May 10 May

8:28 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#2).

Change subject: mb/t400/acpi: Fix ATPR's buffer length ......................................................................

mb/t400/acpi: Fix ATPR's buffer length

Error spoted using acpica version 20190509 (Change-Id: I6779a20 ).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:31 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#3).

Change subject: mb/t400/acpi: Fix ATPR's buffer length ......................................................................

mb/t400/acpi: Fix ATPR's buffer length

Error spoted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

8:51 p.m.

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#4).

Change subject: mb/t400/acpi: Fix ATPR's buffer length ......................................................................

mb/t400/acpi: Fix ATPR's buffer length

Error spoted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

11:05 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32743 )

Change subject: mb/t400/acpi: Fix ATPR's buffer length ......................................................................

Patch Set 4:

(2 comments)

Thanks for fixing this so quickly.

a couple nits about the commit message, but it's good otherwise.

https://review.coreboot.org/#/c/32743/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32743/2//COMMIT_MSG@7 PS2, Line 7: Fix ATPR's buffer length Maybe: "mb/t400/acpi: Update ATPR buffer to fit all entries"

https://review.coreboot.org/#/c/32743/2//COMMIT_MSG@9 PS2, Line 9: spoted spotted

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 10 May 2019 21:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11 May 11 May

12:34 a.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#5).

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

mb/t400/acpi: Update ATPR buffer to fit all entries

Error spotted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

3:25 p.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32743 )

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

Patch Set 5: Code-Review-1

(1 comment)

This is part of a kernel interface (cf. `drivers/gpu/drm/ amd/amdgpu/amdgpu_atpx_handler.c`), please find a solution that doesn't break the ABI.

https://review.coreboot.org/#/c/32743/5/src/mainboard/lenovo/t400/acpi/graph... File src/mainboard/lenovo/t400/acpi/graphics.asl:

https://review.coreboot.org/#/c/32743/5/src/mainboard/lenovo/t400/acpi/graph... PS5, Line 68: These offsets look all correct.

Would be worth to add a comment that they specify different, incompatible structures, `struct atpx_verify_interface` and `struct atpx_px_params` in the kernel. However, as the latter is not implemented here anyway, we can also just drop `MASK` and `FLAG`.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 May 2019 13:25:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

4:10 p.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#6).

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

mb/t400/acpi: Update ATPR buffer to fit all entries

Error spotted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 1 insertion(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

4:10 p.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), Nico Huber, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32743

to look at the new patch set (#7).

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

mb/t400/acpi: Update ATPR buffer to fit all entries

Error spotted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/32743/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

4:33 p.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32743 )

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

Patch Set 7: Code-Review+2

Commit message needs an update.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 May 2019 14:33:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

6:59 p.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32743 )

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 May 2019 16:59:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

13 May 13 May

11:25 a.m.

New subject: Change in ...coreboot[master]: mb/t400/acpi: Update ATPR buffer to fit all entries

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32743 )

Change subject: mb/t400/acpi: Update ATPR buffer to fit all entries ......................................................................

mb/t400/acpi: Update ATPR buffer to fit all entries

Error spotted using acpica version 20190509 (Change-Id: I6779a20).

Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32743 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/lenovo/t400/acpi/graphics.asl 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t400/acpi/graphics.asl b/src/mainboard/lenovo/t400/acpi/graphics.asl index 818ea93..038774f 100644 --- a/src/mainboard/lenovo/t400/acpi/graphics.asl +++ b/src/mainboard/lenovo/t400/acpi/graphics.asl @@ -63,9 +63,7 @@ }) CreateWordField (ATPR, 0x00, SIZE) CreateWordField (ATPR, 0x02, VERS) - CreateDWordField (ATPR, 0x02, MASK) CreateDWordField (ATPR, 0x04, FUNC) - CreateDWordField (ATPR, 0x06, FLAG)

/* Version request */ if (LEqual(Arg0, 0x0))

-- To view, visit https://review.coreboot.org/c/coreboot/+/32743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9cf16a7494667f6dab156c697fb8f8e9966051e Gerrit-Change-Number: 32743 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2179

days inactive

2182

days old

coreboot-gerrit@coreboot.org

11 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Martin Roth (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)