Change in coreboot[master]: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel`
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46689 )
Change subject: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel` ......................................................................
nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel`
This is to reduce differences between Haswell and Broadwell.
Change-Id: I8d6a8ee02e24bee22f0a7b69098ea8430095ba90 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46689/1
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 5a6bb8e..2368e7b 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -287,7 +287,7 @@
static void gma_setup_panel(struct device *dev) { - struct northbridge_intel_haswell_config *conf = dev->chip_info; + struct northbridge_intel_haswell_config *conf = config_of(dev); u32 reg32;
printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n");
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46689 )
Change subject: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel` ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46689
to look at the new patch set (#4).
Change subject: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel` ......................................................................
nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel`
This is to reduce differences between Haswell and Broadwell.
Change-Id: I8d6a8ee02e24bee22f0a7b69098ea8430095ba90 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46689/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46689
to look at the new patch set (#5).
Change subject: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel` ......................................................................
nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel`
This is to reduce differences between Haswell and Broadwell.
Change-Id: I8d6a8ee02e24bee22f0a7b69098ea8430095ba90 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/46689/5
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46689 )
Change subject: nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel` ......................................................................
nb/intel/haswell/gma.c: Use `config_of` in `gma_setup_panel`
This is to reduce differences between Haswell and Broadwell.
Change-Id: I8d6a8ee02e24bee22f0a7b69098ea8430095ba90 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46689 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/northbridge/intel/haswell/gma.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 5a6bb8e..2368e7b 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -287,7 +287,7 @@
static void gma_setup_panel(struct device *dev) { - struct northbridge_intel_haswell_config *conf = dev->chip_info; + struct northbridge_intel_haswell_config *conf = config_of(dev); u32 reg32;
printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n");
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)