Change in coreboot[master]: mb/lenovo/t520/devicetree: Use subsystemid inheritance

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: src:...

Peter Lemenkov (Code Review)

27 Nov 2019 27 Nov '19

10:17 p.m.

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

mb/lenovo/t520/devicetree: Use subsystemid inheritance

Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t520/variants/t520/devicetree.cb 1 file changed, 9 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/37293/1

diff --git a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb index 7893daf..0bfa18f 100644 --- a/src/mainboard/lenovo/t520/variants/t520/devicetree.cb +++ b/src/mainboard/lenovo/t520/variants/t520/devicetree.cb @@ -37,9 +37,13 @@ register "pci_mmio_size" = "2048"

device domain 0 on + subsystemid 0x17aa 0x21cf inherit + device pci 00.0 on end # host bridge device pci 01.0 on end # NVIDIA Corporation GF119M [NVS 4200M] - device pci 02.0 on end # vga controller + device pci 02.0 on + subsystemid 0x17aa 0x21d1 + end # vga controller

chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH # GPI routing @@ -73,7 +77,9 @@ device pci 16.1 off end device pci 16.2 off end device pci 16.3 off end - device pci 19.0 on end # Intel Gigabit Ethernet + device pci 19.0 on # Intel Gigabit Ethernet + subsystemid 0x17aa 0x21ce + end device pci 1a.0 on end # USB2 EHCI #2 device pci 1b.0 on end # High Definition Audio device pci 1c.0 off end # PCIe Port #1 @@ -91,8 +97,7 @@

device pci 1f.0 on #LPC bridge chip ec/lenovo/pmh7 - device pnp ff.1 on # dummy - end + device pnp ff.1 on end # dummy register "backlight_enable" = "0x01" register "dock_event_enable" = "0x01" end

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

HAOUAS Elyes (Code Review)

28 Nov 28 Nov

9:09 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 28 Nov 2019 21:09:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

29 Nov 29 Nov

6:46 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... File src/mainboard/lenovo/t520/variants/t520/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... PS1, Line 45: subsystemid 0x17aa 0x21d1 0x21cf?

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... PS1, Line 81: subsystemid 0x17aa 0x21ce 0x21cf?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 29 Nov 2019 18:46:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

6:50 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... File src/mainboard/lenovo/t520/variants/t520/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... PS1, Line 45: subsystemid 0x17aa 0x21d1

...

0x21cf?

Found here: https://github.com/linuxhw/LsPCI/blob/master/Notebook/Lenovo/ThinkPad/ThinkP...

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 29 Nov 2019 18:50:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:57 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... File src/mainboard/lenovo/t520/variants/t520/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... PS1, Line 45: subsystemid 0x17aa 0x21d1

...

Found here: https://github. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 29 Nov 2019 19:57:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Peter Lemenkov (Code Review)

30 Nov 30 Nov

7:43 p.m.

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... File src/mainboard/lenovo/t520/variants/t520/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/37293/1/src/mainboard/lenovo/t520/v... PS1, Line 81: subsystemid 0x17aa 0x21ce

...

0x21cf?

According to this one it's actually 0x21ce (as some other Lenovo ThinkPad mainboards)

https://github.com/linuxhw/LsPCI/blob/master/Notebook/Lenovo/ThinkPad/ThinkP... T520 4242DV7/4425DA2AB25E/NEON-18.04/4.15.0-45-GENERIC/X86_64/7DF79D0141#L42

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 30 Nov 2019 19:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org Gerrit-MessageType: comment

Patrick Georgi (Code Review)

6 Dec 6 Dec

3:21 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Dec 2019 15:21:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3:21 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37293 )

Change subject: mb/lenovo/t520/devicetree: Use subsystemid inheritance ......................................................................

mb/lenovo/t520/devicetree: Use subsystemid inheritance

Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37293 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t520/variants/t520/devicetree.cb 1 file changed, 9 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve

device pci 1f.0 on #LPC bridge chip ec/lenovo/pmh7 - device pnp ff.1 on # dummy - end + device pnp ff.1 on end # dummy register "backlight_enable" = "0x01" register "dock_event_enable" = "0x01" end

-- To view, visit https://review.coreboot.org/c/coreboot/+/37293 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iffeb634c73f58aa1cddac5210d75fda75a3d5e92 Gerrit-Change-Number: 37293 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1818

days inactive

1827

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Patrick Rudolph (Code Review)
Peter Lemenkov (Code Review)