Attention is currently required from: Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69900 )
Change subject: soc/intel/apollolake/include/soc/pmc.h: Add file ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69900/comment/f91b28b4_5c7aafc7 PS5, Line 10: pm.h
Why not rename this file?
I was thinking about it, but when I saw what other SoCs include in the pm.h and pmc.h and that it is not always consistent, I hesitated to rename it. The overlap of pm.h and pmc.h is not quite clear to me. Furthermore, renaming could cause many unwanted side effects that could easily miss my attention accidentally due to too many changes involved. Let me know WDYT
-
Michał Żygowski (Code Review)