Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73487 )
Change subject: util/ifdtool: Add option to create FMAP template ......................................................................
Patch Set 9:
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/73487/comment/80a8b403_71483c0c PS7, Line 941: -p $(CONFIG_IFD_CHIPSET)
According to ifdtool's integrated help, -p is used to handle platform-specific quirks. […]
The help is not entirely correct. If you supply a platform it will use the IFD format of that platform. If you don't supply a platform, than IFDTOOL will guess the IFD format. But that guessing only works for older platforms (if I remember correctly) and on the platform I tested this on the IFD format was always guessed wrong and it is not always easy to catch that in an entire coreboot build log. But this is meant only as a fallback for those mainboards that don't supply their own FMAP. Also IMHO: I am not a fan of guessing, especially while building.
-
Maximilian Brune (Code Review)