Change in ...coreboot[master]: mb/google/hatch: Set VmxEnable to 1

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Furquan Shaikh (Code Review)

15 Feb 2019 15 Feb '19

8:56 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31438

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

mb/google/hatch: Set VmxEnable to 1

This change sets VmxEnable to 1 to match the kernel setting.

BUG=b:124518711

Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/31438/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index aaef663..1cb570c 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -49,6 +49,7 @@ register "SataPortsEnable[1]" = "1" register "SataPortsDevSlp[1]" = "1" register "satapwroptimize" = "1" + register "VmxEnable" = "1" # Enable System Agent dynamic frequency register "SaGv" = "SaGv_Enabled" # Enable heci communication

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Duncan Laurie (Code Review)

15 Feb 15 Feb

9:56 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 15 Feb 2019 20:56:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rizwan Qureshi (Code Review)

16 Feb 16 Feb

11:01 a.m.

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31438/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/31438/1/src/mainboard/google/hatch/variants/... PS1, Line 52: register "VmxEnable" = "1" I think we need to do this https://review.coreboot.org/c/coreboot/+/31442 before we select the config. Since we are skipping MIP init in FSP VMX will not be configured.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Comment-Date: Sat, 16 Feb 2019 10:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ronak Kanabar (Code Review)

15 Apr 15 Apr

11:30 a.m.

Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31438/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/#/c/31438/1/src/mainboard/google/hatch/variants/... PS1, Line 52: register "VmxEnable" = "1" we don't need this change now. we are enabling Vmx using Kconfig. Please check CB:32117

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-CC: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Comment-Date: Mon, 15 Apr 2019 09:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

29 May 29 May

10:27 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Patch Set 1:

So what's the verdict here: VmxEnable in devicetree or in Kconfig?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-CC: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Comment-Date: Wed, 29 May 2019 20:27:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:28 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Patch Set 1:

...

Patch Set 1:

So what's the verdict here: VmxEnable in devicetree or in Kconfig?

This change should not be required now that https://review.coreboot.org/c/coreboot/+/32117 has landed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-CC: Ronak Kanabar ronak.kanabar@intel.com Gerrit-Comment-Date: Wed, 29 May 2019 20:28:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Jun 3 Jun

3:27 p.m.

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31438 )

Change subject: mb/google/hatch: Set VmxEnable to 1 ......................................................................

Abandoned

superseded by CB:32117

-- To view, visit https://review.coreboot.org/c/coreboot/+/31438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20f9282a94dc502e963578c435061ffe52ce83d3 Gerrit-Change-Number: 31438 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Rajat Jain rajatja@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-CC: Ronak Kanabar ronak.kanabar@intel.com Gerrit-MessageType: abandon

2000

days inactive

2108

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Rizwan Qureshi (Code Review)
Ronak Kanabar (Code Review)