[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email )

Change subject: soc/mediatek/mt8196: Add srclken_rc drivers
......................................................................

Patch Set 2:

(17 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85842/comment/72696bda_a32e63b4?usp... :
PS1, Line 9: Mt8196
> MT8196

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/e3dbfd83_3ea81fe1?usp... :
PS1, Line 8: 
           : Mt8196 use new RC mode with clk_buf driver, and need srclken_rc to send
           : cmd.
> Can you elaborate more ? What is RC mode ? What is this driver for ?

Done

Commit Message:

https://review.coreboot.org/c/coreboot/+/85842/comment/3a69a782_245958e4?usp... :
PS2, Line 9: need
needs

https://review.coreboot.org/c/coreboot/+/85842/comment/e805b473_e0829b53?usp... :
PS2, Line 9: use
uses

https://review.coreboot.org/c/coreboot/+/85842/comment/7d85315e_465177dd?usp... :
PS2, Line 10: ,
remove

https://review.coreboot.org/c/coreboot/+/85842/comment/37af66a6_86b00513?usp... :
PS2, Line 11: , and so on
remove

File src/soc/mediatek/mt8196/include/soc/srclken_rc.h:

https://review.coreboot.org/c/coreboot/+/85842/comment/2357ed62_9d4f469e?usp... :
PS1, Line 192:
> remove one tab

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/0d3e8481_88b18fce?usp... :
PS1, Line 202:
> Remove 2 tabs

Done

File src/soc/mediatek/mt8196/srclken_rc.c:

https://review.coreboot.org/c/coreboot/+/85842/comment/a490502b_db541195?usp... :
PS1, Line 69: #define SW_BBLPM_HIGH		1
            : #define SW_BBLPM_LOW		0
            : #define SW_FPM_HIGH		1
            : #define SW_FPM_LOW		0
> use enum ?

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/fe997c5e_e0ffc1a9?usp... :
PS1, Line 149: |
> move `|` to above line

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/86b32352_486e34a0?usp... :
PS1, Line 278: DCXO_SETTLE_BLK_EN
> align with first param

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/c13dcb73_76ff75d3?usp... :
PS1, Line 318: id, read32(&rc_regs->rc_mxx_srclken_cfg[id]));
> move to above line

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/fb6aa213_e78d0bd1?usp... :
PS1, Line 320:
> remove one blank line

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/117e53dd_9ce99ae9?usp... :
PS1, Line 359: retry(ACK_DELAY_TIMES, (read32(&rc_status_regs->rc_mxx_req_sta_0[chn]) & 0xa) == state, udelay(ACK_DELAY_US))
>

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/87f493f6_9f6bbeb1?usp... :
PS1, Line 360: 0x%x
> %#x

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/76acfe36_d6ad0191?usp... :
PS1, Line 362: chn,
> move to the above line

Done

https://review.coreboot.org/c/coreboot/+/85842/comment/9b14fb0b_80986355?usp... :
PS1, Line 385: dsb
> I have the same question.

Done