Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51658 )
Change subject: soc/intel/alderlake: Add enum for HDA audio configuration
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/51658/comment/bf9befa9_2c3aa572
PS2, Line 121: HDA_TMODE_4T = 2,
I wasn't sure what was the definitive source, the header file or the UPD help text?
https://github.com/coreboot/coreboot/blob/master/src/vendorcode/intel/fsp/fs...
I was referring to the comment in the header file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2834d6f4ce1651a609c5563af375f6e365d931fa
Gerrit-Change-Number: 51658
Gerrit-PatchSet: 2
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 24 Mar 2021 02:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment