Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21217 )
Change subject: amd/sb/sb700: Allocate wide LPC I/O devices where possible ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patch looks fine but indentation levels could be reduced/improved so that's easier to read on smaller screens. Can happen in a follow up patch ofc.
https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c File src/southbridge/amd/sb700/lpc.c:
https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@a166 PS1, Line 166: : Could the indentation be reduced by simply doing "continue" on the opposite of this conditional?
https://review.coreboot.org/#/c/21217/1/src/southbridge/amd/sb700/lpc.c@222 PS1, Line 222: "I/O window exhaustion\n", __func__, dev_path(child), base, end); could this have a few tabs less so it fits the screen more easily?
-
Arthur Heymans (Code Review)