Change in coreboot[master]: ec/lenovo/h8/acpi: fix wrong calculation - coreboot-gerrit

8 Apr 2021


      Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Michael Niewöhner, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph, HAOUAS Elyes.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52144 )
Change subject: ec/lenovo/h8/acpi: fix wrong calculation
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52144/comment/1fa69d32_c4799984 
PS3, Line 10: BUG
hmmm... ok, the kind of BUG that triggers a kernel warning, or a panic if enabled.
https://review.coreboot.org/c/coreboot/+/52144/comment/17b2c31d_4c50a79e 
PS3, Line 11: wrongly converted
nit: since this works as a compound adjective, it should be hyphenated: `wrongly-converted`
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52144
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cea8f56eb0a674005582c87cad89f10a02d0701
Gerrit-Change-Number: 52144
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Evgeny Zinoviev me@ch1p.io
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment